-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][misc] Class conflict during jetcd-core-shaded shading process #23641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][misc] Class conflict during jetcd-core-shaded shading process #23641
Conversation
… to execute shade multiple times without clean
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good work @Shawyeok. Thanks for finding the root cause and addressing the problem.
|
@Shawyeok Please submit a similar PR to BookKeeper for jetcd-core-shaded. |
@lhotari |
…pache#23641) (cherry picked from commit 3e108da) (cherry picked from commit 6c33bf1)
…pache#23641) (cherry picked from commit 3e108da) (cherry picked from commit 6c33bf1)
Motivation
In the latest release candidates (
3.0.8-candidate-1,4.0.1-candidate-1), the jetcd-core-shaded module shading issue persists. This occurs because themaven-shade-pluginincludes the current project artifact in the shade process. Injetcd-core-shaded, we copyio.etcd.jetcd.*into thejetcd-core-shadedjar without relocation. As a result, when theinstallordeploygoals are executed without cleaning thetargetfolder, class conflicts arise betweenio.etcd.jetcd.*insideorg.apache.pulsar:jetcd-core-shaded.jarandio.etcd:jetcd-core.jar.#23604 attempted to resolve this issue but failed to account for build and deploy in separate steps during the release process.
Verifying this Change
To verify this patch, follow these steps:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Shawyeok#20